Add Monitor Refresh Rate Changer plugin#685
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48eb97e240
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9db007e39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Add missing ActionKeyword (hz) - Fix Author capitalization - Update Version to 1.0.0 - Update download URL to v1.0.0 release
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfb4aecd3a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "ID": "f38c9470-7d31-401e-88ca-06c964bb3fc3", | |||
| "ActionKeyword": "hz", | |||
There was a problem hiding this comment.
This repository only permits the fields listed in necessary_fields or optional_fields in ci/src/_utils.py, and ActionKeyword is not one of them. With this new file present, python -m pytest ci/src/validator.py -q fails in test_optional_fields for this manifest, so the submission cannot pass CI until this key is removed.
Useful? React with 👍 / 👎.
| "Language": "python", | ||
| "Website": "https://github.com/psycodess/hz-plugin", | ||
| "IcoPath": "https://cdn.jsdelivr.net/gh/psycodess/hz-plugin@main/Images/app.png", | ||
| "UrlDownload": "https://github.com/psycodess/hz-plugin/releases/download/v1.0.0/hz-plugin.zip", |
There was a problem hiding this comment.
For this new plugin, the manifest advertises v1.0.0, but the upstream psycodess/hz-plugin repository currently only exposes v0.2.0 and v0.1.0-alpha tags/releases, so there is no v1.0.0 release asset at this path. Flow will try to download exactly this UrlDownload during store installation, causing installs to fail until it points at a published GitHub release ZIP or that release is created.
Useful? React with 👍 / 👎.
|
Hi @psycodess seems you have another PR for this plugin #683, let's keep only one please. If you need help with GitHub workflow, have a look at our documentation please- https://www.flowlauncher.com/docs/#/py-setup-project?id=_1-add-github-workflow. Please also action the review comments. |
2 participants
No description provided.